Fixed boto_vpc_test failure #34141
Merged
Fixed boto_vpc_test failure #34141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might need to change the version check here. Not all versions of |
|
Ah, didn't realize that. I'll update. |
|
@rallytime Updated the check. Let me know if that seems right. |
| try: | ||
| return LooseVersion(moto.__version__) | ||
| except AttributeError: | ||
| import pkg_resources |
There was a problem hiding this comment.
Why are we doing two imports like this?
There was a problem hiding this comment.
No reason in particular. I just mimicked how it was in _has_required_moto(). I can pull them out, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With new moto version 0.4.25, is_default is set to True, while on older versions it is False. This lets this test be backwards compatible with older versions of moto.
It also changes the tags to be unicode strings.
What issues does this PR fix or reference?
Failing test on jenkins, across all branches.
Tests written?
Yes